Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev swallowing errors and showing 404 instead, since 5.0.1-canary.5 #3864

Closed
majelbstoat opened this issue Feb 21, 2018 · 0 comments · Fixed by #3877
Closed

Dev swallowing errors and showing 404 instead, since 5.0.1-canary.5 #3864

majelbstoat opened this issue Feb 21, 2018 · 0 comments · Fixed by #3877
Assignees

Comments

@majelbstoat
Copy link

majelbstoat commented Feb 21, 2018

When developing, it's useful to see if changed dependencies break something. Since 5.0.1-canary.5, instead of error overlays, under certain circumstances there is now a blank 404 page, with no console errors on either client or server console.

I upgraded react-apollo to 2.1.0-beta.0. There is some breakage with this package in my codebase which under 5.0.1-canary.4 shows the following in the browser:

Object(...) is not a function
TypeError: Object(...) is not a function
    at Object.libApolloMutationsCreateCredentialsTs (/src/app/lib/apollo/queries/withCredentials.ts:5:19)
    at __webpack_require__ (/src/app/.next/dist/bundles/pages/webpack/bootstrap 09a1c451b2869cd2289b:25:1)
    at Object.libApolloMutationsIndexTs (/src/app/.next/dist/bundles/pages/home.js:2367:60)

This makes it very clear that something is wrong with the apollo setup. Under 5.0.1-canary.5, hitting the same page gives a blank 404 page, which makes it very hard to figure out what went wrong. This behaviour is still present in canary.6.

(This report is not about the breakage itself, but the lack of error info.)

Perhaps this is because I'm doing SSR, and Next is not loading a script it knows is broken? Given the few patches that landed between canary.4 and canary.5, this one looks like the most likely candidate: #3749.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants