Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<link rel='preload' ..> before <meta charset="utf-8"> #3210

Closed
1 task done
schoenwaldnils opened this issue Oct 30, 2017 · 3 comments
Closed
1 task done

<link rel='preload' ..> before <meta charset="utf-8"> #3210

schoenwaldnils opened this issue Oct 30, 2017 · 3 comments

Comments

@schoenwaldnils
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

<meta charset="utf-8"> should be the first element in the <head>

Current Behavior

<NextScript /> prepends the preloadDynamicChunks in the head.
https://github.com/zeit/next.js/blob/canary/server/document.js#L87

Context

https://sonarwhal.com/docs/user-guide/rules/meta-charset-utf-8/

Your Environment

Tech Version
next 4.1.3
node 8.4.0
@yashha yashha mentioned this issue Oct 30, 2017
Merged
@schoenwaldnils
Copy link
Contributor Author

@timneutkens this PR doesn't solve this issue. sadly.

@timneutkens
Copy link
Member

@schoenwaldnils it's not released yet. Have you tried the branch?

@schoenwaldnils
Copy link
Contributor Author

Seems to work with ~4.2.1

@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schoenwaldnils @timneutkens