Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change on 11.1.0 refactor of shared folder #28011

Closed
mercuriete opened this issue Aug 12, 2021 · 3 comments
Closed

Breaking change on 11.1.0 refactor of shared folder #28011

mercuriete opened this issue Aug 12, 2021 · 3 comments
Labels
bug Issue was opened via the bug report template.

Comments

@mercuriete
Copy link

mercuriete commented Aug 12, 2021

What version of Next.js are you using?

11.1.0

What version of Node.js are you using?

LTS

What browser are you using?

Chrome

What operating system are you using?

Linux

How are you deploying your application?

NA

Describe the Bug

our developers had to modify the code to compile due a breaking change:

from:

import { RouterContext } from 'next/dist/next-server/lib/router-context'

to

import { RouterContext } from 'next/dist/shared/lib/router-context'

Please bump nextjs to v12 or revert the changes.

Thanks.

Expected Behavior

a minor version should compile without changes on the code.

To Reproduce

just bump the version on package.json to 11.1.0

@mercuriete mercuriete added the bug Issue was opened via the bug report template. label Aug 12, 2021
@mercuriete
Copy link
Author

If you feel this is a bad usage of the library, close this issue.

@timneutkens
Copy link
Member

Posted a reply here: #26734 (comment). You're using Next.js internals which can change at any time.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

No branches or pull requests

3 participants