Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially uncaught error in Next.js router #15063

Closed
Timer opened this issue Jul 10, 2020 · 2 comments · Fixed by #14848
Closed

Potentially uncaught error in Next.js router #15063

Timer opened this issue Jul 10, 2020 · 2 comments · Fixed by #14848
Milestone

Comments

@Timer
Copy link
Member

Timer commented Jul 10, 2020

As caught by @Janpot:

@Timer Timer added this to the 9.x.x milestone Jul 10, 2020
@Janpot
Copy link
Contributor

Janpot commented Jul 10, 2020

Should probably just convert this whole change method to async/await. That would solve it. Will PR after #14848 is merged. Will also take a look at other functions that have unnecessary promise constructor logic instead of leveraging async/await.

edit

async/await will blow up the bundle size. I just removed the Promise constructor in #14848. that should make it less prone to these sort of errors. Promise chains inside of a Promise constructor are an anti-pattern

@Timer Timer modified the milestones: 9.x.x, iteration 5 Jul 20, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants