$RefreshReg$ is not defined in web worker after upgrading to 9.4.0

[Jarred-Sumner]

Bug report

I believe this is a React Refresh-related issue.

Potentially relevant:

• ReactNativeJS ▶︎ Property '$RefreshReg$' doesn't exist facebook/react-native#25684
• https://github.com/facebook/react/blob/master/packages/react-refresh/src/__tests__/ReactFresh-test.js

Describe the bug

After upgrading to Next.js 9.4.0, workers throw the following exception on load:

Uncaught ReferenceError: $RefreshReg$ is not defined
    at Module.eval (blocks.ts:239)
    at eval (blocks.ts:296)
    at Module../shared/blocks.ts (48ba4b417edc794a158b.worker.js:311)
    at __webpack_require__ (48ba4b417edc794a158b.worker.js:29)
    at Module.eval (WorldChunk.ts:12)
    at eval (WorldChunk.ts?c4f7:22)
    at Module../lib/Data/WorldChunk.ts (48ba4b417edc794a158b.worker.js:115)
    at __webpack_require__ (48ba4b417edc794a158b.worker.js:29)
    at Module.eval (WorldChunkReader.worker.ts?024a:1)
    at eval (WorldChunkReader.worker.ts?024a:21)

To Reproduce

1. Configure worker-loader like so in next.config.js:

config.module.rules.unshift({
  test: /\.worker\.(js|ts|tsx)$/,
  loader: "worker-loader",
  options: {
    name: "static/[hash].worker.js",
    publicPath: "/_next/",
  },
});

// Overcome webpack referencing `window` in chunks
config.output.globalObject = "self";

2. Load a worker
3. See error

Expected behavior

No error, workers load successfully as in Next 9.3

Screenshots

System information

• OS: macOS
• Browser (if applies) Chrome
• Version of Next.js: 9.4.0
• Version of Node.js: 13.12.0

[Jarred-Sumner]

In my case, I was able to work around this issue by ensuring that there is no direct overlap between:

• Modules imported in React components
• Modules imported in Worker bundles

@next/react-refresh-utils thought it was a React Refresh boundary, so it adds its metadata to the file. That metadata breaks workers since React isn't in the worker (though if you import * as React in the worker it still doesn't work). So you need to find a way to make it not think there are React Refresh boundaries in the workers.

This isn't a great fix because it meant moving functions to a bunch of individual files

[Jarred-Sumner]

I ran into this issue again and couldn’t use the previous workaround.

This time, I worked around it by renaming exported functions that are shared between React and Worker code to have a number in the function name 😅. This causes the heuristic for checking whether or not something is potentially a React component to return false (which is what React Refresh uses for refresh boundaries).

[Timer]

Can someone please provide a clonable complete reproduction so we can look into this?

[Jarred-Sumner]

@Timer here you go: https://github.com/Jarred-Sumner/repro-refreshregistry

[utxo-detective]

I began seeing this same issue when I upgraded to next 9.4 from 9.3. It's only impacting dev for me, when I deployed it to vercel, the error was not there

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.