Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error on eval-script.js (22,1) for IE11 #1207

Closed
manuelro opened this issue Feb 19, 2017 · 6 comments
Closed

Syntax error on eval-script.js (22,1) for IE11 #1207

manuelro opened this issue Feb 19, 2017 · 6 comments

Comments

@manuelro
Copy link

There is a syntax error in one of Next's dependencies. The file's name is eval-script.js and is located at next/dist/lib/eval-script.js. This only happens on IE11 and previous versions.

The code this is prompting as buggy is at line 22 of the aforementioned file.

function evalScript(script) {
  var module = { exports: {} };

  eval(script); // eslint-disable-line no-eval
  return module.exports;
}

Next version: next@^2.0.0-beta.25

Any ideas how to make this IE11 compatible?

@khrome83
Copy link
Contributor

Have you tried a more recent version to see if the error still exists?

@manuelro
Copy link
Author

I've updated Next package to 2.0.0-beta.31 but the error persists.

@timneutkens
Copy link
Member

cc @arunoda @nkzawa I wonder if we should even do that eval in production mode.

@arunoda
Copy link
Contributor

arunoda commented Feb 20, 2017

@timneutkens with the current setup we've to use eval. But I'd like to use something different is later versions.

@timneutkens
Copy link
Member

Okay 👍🏻

@timneutkens
Copy link
Member

Closing this in favor of #1301

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants