-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Cannot find module 'postcss-flexbugs-fixes' after upgrading to 9.3.4 #11783
Comments
You need to install these dependencies yourself, otherwise you're relying on an implicit dependency from Next.js. We might need to update the docs to make this more clear. |
The moment you reference a dependency in your application configuration like postcss.config.js it's a dependency of your project. Definitely can be mentioned in the docs that you have to install it, but you can't reference internal npm dependencies of other dependencies (like next.js) in a safe way as dependencies can change at any time. An example would be (generic node.js example), you add If you want to rely on Next.js configuring postcss you don't add postcss.config.js, otherwise it's up to you as a user to configure it and add the correct dependencies. postcss-flexbug-fixes was not removed from Next.js for example. |
That's fair, but the documentation should also be updated when you change something like this. If a user right now goes and follows the advice in your docs, their application will break! Again, the ideal solution would be to offer a way of extending or importing your base config. |
Let's keep this open to improve the docs, mention installing the deps basically. |
I'd gladly update the docs if I knew what config you were using now. |
It's the same config, only thing that has to be mentioned is that the user has to install the mentioned dependencies like |
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Bug report
Describe the bug
next build
fails with the error in the title after updating to 9.3.4 with a custom PostCSS config following the current documentationTo Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
postcss.config.js
with the contents specified hereExpected behavior
Documentation needs to be updated with the correct "base" PostCSS config for 9.3.4. I know you apparently removed
postcss-flexbugs-fixes
, but I have no idea what else might have changed.The text was updated successfully, but these errors were encountered: