-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an intentional loading sequence #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
Issues I'm seeing in production:
|
I tried to make comments a route group, hoping that this would make the "instant loading UI" prefetch the story above the fold. But prefetching doesn't seem to do what I want. Also, there's a build failure but I don't know what it is because it seems like CI is private. |
This reverts commit 7abb3f0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the demo feel more aligned with the UX expected from HN:
With these changes combined, I believe it works much closer to what people expect an HN demo to behave.
Before:
before.mov
After:
after2.mov
If we want to introduce the shell for the front page I think we can do that, but we need to be a lot more careful about how it behaves. I suggest that it shouldn't show up on pagination (that feels disruptive), and it should definitely not show up for the story page.