Remove the Suspense boundary for individual items #15
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/next-rsc-demo/FT3wzMadDiwbM3QeMpyKLJaE4Qkm |
|
When I tried this locally I got weird hydration errors. Is that specific to me? |
|
Not specific to you, that's something we are looking into — reverting to a previous Next.js release should fix it (#14). |
📝 Changed routes:
|
|
Should we also fix up the parent suspense boundary to be more natural than a spinner? For example by giving body min height and then making the fallback empty, or something. |
|
Good call, min div height with some skeletons inside (that matches the item height) will be better. |
|
Updated with animating skeletons: https://next-rsc-demo-git-shu-0653.vercel.sh/rsc. Should be good for now I think. |
|
Can we make it so that the height of the skeleton is the same as the height of the content? Do we not know the number of the rows or the size of each? |
|
❤️ |
|
Sometimes when I refresh I get this:
But not every time. |
|
When it's broken, I can see the scripts on the right are missing from the HTML:
|
As mentioned in #13 (comment), we think removing the spinners for individual items will reduce layout shift and improve the overall experience of this app.