Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minification #62

Closed
rauchg opened this issue Nov 26, 2018 · 1 comment
Closed

Minification #62

rauchg opened this issue Nov 26, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@rauchg
Copy link
Member

rauchg commented Nov 26, 2018

Currently, minimize: true being turned on is failing for an unknown reason with all integration tests.

We should be mindful here to only enable optimizations that are deemed safe for most Node.js programs and npm modules (including those that perform runtime introspection or reflection).

The pros / cons of this have to be carefully evaluated in contrast with what #51 provides.
@rauchg rauchg added the enhancement New feature or request label Nov 26, 2018
@developit
Copy link

Would it be useful to start off with simple whitespace + comment removal?

@navossoc navossoc mentioned this issue Nov 27, 2018
Closed
@guybedford guybedford mentioned this issue Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rauchg @developit