Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Support for Tweaking Modifier Keys #783

Closed
rye opened this issue Oct 5, 2016 · 3 comments
Closed

Rich Support for Tweaking Modifier Keys #783

rye opened this issue Oct 5, 2016 · 3 comments

Comments

@rye
Copy link

rye commented Oct 5, 2016

#330 references remapping the Option key and using that as Meta on OS X.
#686, which introduced support for this, resolved #330, but I think that it wasn't enough to satisfy most users, especially those like myself who use Emacs in terminal and require having full access to all the modifiers.

I'd prefer to see something more like:

"modifierKeys": {
  "cmd": "super",
  "option": "meta"
}

In my configuration, personally.

lib/hterm.js will almost certainly need to be modified, specifically the Keyboard.onKeyDown callback.

Some questions to raise would be:

  • What style would users like to see for a "modifierKeys" configuration?
  • Is there even anything we can do to prevent operating systems like macOS from stealing these keybindings and entering 'special' characters?

I can and would love to work on this, but I'm not very familiar with the inner workings of things and I'd need to educate myself on VT.

@ferakpeter
Copy link

ferakpeter commented Oct 11, 2016

I've played around with the configurations for the meta keys, I would prefer your config style. However, the way cmdIsMeta is working right now, it's not usable, it overrides the hotkeys for new tab and new windows, and so forth. So Hyper loses core features in that case. And on windows and mac platforms there is no cmd button, so the setting with cmdIsMeta would be misleading. Your configuration style can solve this.

So from my perspective there's only one question that should be answered in the config: do you want use ALT as meta? Or do you want to not have a meta key passed to the terminal? (in the second case ALT is useful for arrow navigation)

@curioussavage
Copy link

I like the config too, and once #925 is resolved the cmd key issue will be resolved too.

@rye rye mentioned this issue Nov 17, 2016
@ppot ppot mentioned this issue Feb 10, 2017
26 tasks
@ppot ppot mentioned this issue Apr 29, 2017
@ppot
Copy link
Contributor

ppot commented Aug 15, 2017

close in #1876

@ppot ppot closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants