Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option for selected text color setting #2934

Open
2 tasks done
shaneknysh opened this issue Apr 25, 2018 · 4 comments
Open
2 tasks done

Add a config option for selected text color setting #2934

shaneknysh opened this issue Apr 25, 2018 · 4 comments

Comments

@shaneknysh
Copy link

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • Windows 10

  • Hyper.app 2.0.0 stable:

  • hyper.js

Issue

There is a config option for selection color
selectionColor: <color>

However, if you use this without a opacity value the selection will hide the text. It would be nice to have a way to set the selection color and the selection text color so the text in the selection would still be visible.

selectionColor: <color>
selectionText: <color>

possible default values would be to invert the foreground and background colors.

@edahlseng
Copy link

Just looking at Hyper today, and wishing this feature existed! I can't find a way to set this with CSS since the text is rendered in the canvas.

@Luxcium
Copy link

Luxcium commented May 11, 2019

Add config option for selected text color setting #3655

I am trying hard to find a solution but it seam I don't have enough expertise for now ...

I am inside 'xterm.js/src/renderer/Types.ts' and it seems that there is no foreground colour for a selection:

export interface IColorSet {
    foreground: IColor;
     background: IColor;
    cursor: IColor;
    cursorAccent: IColor;
    selection: IColor;
    ansi: IColor[];
}

@Luxcium
Copy link

Luxcium commented May 11, 2019

I would like to get into xtermjs/xterm.js and change it to have this or something similar:

export interface IColorSet {
  foreground: IColor;
  background: IColor;
  cursor: IColor;
  cursorAccent: IColor;
  selection: IColor; 
  selectionForeground?: IColor;
  selectionBackground?: IColor;
  ansi: IColor[];
}

@tukusejssirs
Copy link

I have just today found out about Hyper. I like it, but I wish the selectionColor could be configured to inverted the selected text normal colours (bg colour → fg colour and fg colour → bg colour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants