-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts are Heavier in v2.0 #2856
Comments
@sikthought could you try setting it to |
I found that my fonts are thinner since updating, and the fontWeight options are having no effect. |
From #2714 (comment) it sounds like |
The Maybe related to old files from a previous release? |
@Tyriar — Sorry, it doesn't seem to be effecting anything ( ( I also checked to be sure, and Terminal and iTerm are set on |
@sikthought Hyper in the screenshot is using a different font though (look at the |
@Tyriar — Hmmmm… Here's what I have, tho: I also just checked VSCode, it is also set with IBM Plex Mono and is showing what the iTerm and Terminal is showing. So, it looks like Hyper isn't loading Plex Mono at all and is falling back to Fira Code (I also tried (all with Fira Code this time) |
So, I just tried a fresh install (deleting the app and all files associated with it), to see if a clean config will help. I am getting Plex Mono to load fine—so all my |
@sikthought – I hate to do this, but your Hyper config is calling for “IMB Plex Mono”. |
Eagle eye @neeklamy 🦅 |
@neeklamy — FML 🤣 Well, it worked itself out in the end anyway. 👍🏼 |
I'm having this issue, i just can't change the weight of the font since v2.0... it's always bold. Any solution? Downgraded to 1.4.6 and theres no issue Edit: Hyper updated by itself without im accepting it and now im stuck with bold fonts on v2.0... how to disable auto update? |
You can disable updates for stable by adding |
Am also having trouble adjusting fontWeight in 2.0.0-canary.18 on macOS. This is Fira Code with a ostensible fontWeight of "100" The same text rendered by VS Code's integrated terminal for comparison. It's subtle, but Hyper is definitely blurrier. They look identical if I set VS Code's |
We need to double check that this is actually set and is getting forwarded to xterm 👍 |
I did a little bit of debugging on this issue and compiled Hyper with I believe it's now up to @chabou to check if this issue is due to an older upstream xterm version being used by Hyper or due to changes on his fork. |
@rfgamaral Not exactly. My fork has an unmerged PR for huge performance gain. And this is this xterm PR that introduced this regression. But It has been fixed in this PR after my feedback: xtermjs/xterm.js#1327 (comment) I'll update my fork ASAP. |
Huge performance gain? Awesome! Thanks for the clarification on the issue :) |
@chabou Just wondering if you got to update your fork and consequentially Hyper xterm dependency? |
I loaded up xterm 3.4.1 and it seems to work pretty well. For those who stumble across this, don't make my mistake: keep in mind that there's also For example, with Menlo from the default fontFamily ("Menlo, DejaVu Sans Mono, Lucida Console, monospace") I tried and only noticed a difference between normal (300) and bold (600). 'light' seems to be unrecognized (100 and 200 are recognized as normal) - I see the same thing that I see with 'aweklfajw': The one I'm using, Source Code Pro, also doesn't recognize 'light' and shows the same weirdness. But it does have different shades for 400 and 500 |
Will be fixed by #3032 |
@jcrben thank you for your insights. |
1 similar comment
@jcrben thank you for your insights. |
Any update on this? even on latest canary the problem is there |
This discussion in xterm.js seems possibly related: Font rendering weight heavier than in 2.x |
I use FiraCode-Retina.ttf,the font is heavier. After use FiraCode-Light.ttf, All is normal. |
Oh, found that issue ticket. Yep, all the fonts are heavy / gravy meanwhile in iTerm2 you can get "retina" mod which makes them even more slim (I wish it would also trim down bold weights a little bit correspondingly but I've planted a ticket in regards already). All-in-all: Hyper is close to unusable due to this. |
Issue
After updating to v2.0 I noticed that the font rendering is heavier than before. I've tried changing the
fontWeight
setting to either"light"
or "thin
" and there's no change. Below I've included a screen shot of how Hyper compares to iTerm and Terminal.(iTerm/Terminal/Hyper)
Editing other font values in my
.hyper.js
file does seem to work appropriately (fontSize
,fontFamily
…), so Hyper is responding to my.hyper.js
.Thanks
The text was updated successfully, but these errors were encountered: