Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git automerge - nano edit fail #1279

Closed
B3B8 opened this issue Dec 20, 2016 · 4 comments
Closed

Git automerge - nano edit fail #1279

B3B8 opened this issue Dec 20, 2016 · 4 comments
Labels
🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@B3B8
Copy link

B3B8 commented Dec 20, 2016

  • [ X] I am on the latest Hyper.app version
  • [X ] I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: MAC OS SIERRA 10.12.2
  • Hyper.app version: 1.0.0
  • Link of a Gist with the contents of your .hyper.js:
  • Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app:

Issue

When git open the automerge editor (Nano) I write commit, than I use ctr+O (writeout) to save info and when I use ctr+X (exit) to close, hyper doesn't close nano and I don't understand how to go on with terminal ..
I try to use another pc with Ubuntu 16. Same problem with the same hyper version 1.0.0 . I can't close nano after commit message.
I try to edit hosts with nano (sudo nano /etc/hosts), hyper open nano, add new host, and everythings is ok!
Where I'm doing wrong when git open auotmerge editor ?

@Specro
Copy link
Contributor

Specro commented Dec 20, 2016

Have you tried CtrlShiftX?

Dupe #1069

@nbolten
Copy link

nbolten commented Dec 20, 2016

This is a dupe of #1069 and #1132. Basically, hyper uses Ctrl as its mod key by default on Windows and Linux, which is not ideal. This does not impact Mac users, as Cmd is used there.

I've put in a pull request at #1191 and would appreciate any confirmations/feedback you can provide there.

@B3B8
Copy link
Author

B3B8 commented Dec 27, 2016

Great!! Ctrl Shift X Also on Linux (ubuntu 16)
@Specro Thanks 👍

@albinekb albinekb added the 🐛 Type: Bug Issue pertains to something wrong within Hyper label Jan 4, 2017
This was referenced Apr 30, 2017
@ppot
Copy link
Contributor

ppot commented Aug 15, 2017

close in #1876

@ppot ppot closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests

5 participants