Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When approved: Show the "submit for review" section only after having saved the entry for the first time. #29

Closed
outline4 opened this issue Aug 8, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@outline4
Copy link

outline4 commented Aug 8, 2018

Once the entry is approved, please only show the "submit for review" section after saving for the first time.
It does not make sense to submit an entry without having made any changes.
I can see my clients submitting an entry multiple times.

And if we're at it: Please consider moving the "approved"-section ABOVE the submit for review section.

It's great to have workflow for craft v3!
Thanks a lot!

@engram-design
Copy link
Member

That's a tricky one, Workflow doesn't current have any concept of checking whether entry content has changed or not. We also can't rely on the versioning being enabled, as some sections aren't. We'll look at adding this in.

What's the reasoning behind having the approved items above the new submission button? The reason for it being first is so that its not lost vertically on the page if there are multiple submissions (approved or otherwise).

@engram-design engram-design added the enhancement New feature or request label Nov 10, 2018
@engram-design
Copy link
Member

This has been addressed in 1.1.0. Now, the "Submit for review" button saves and submits content. There still aren't and specific checks on whether content has changed, but this is similar to how a regular save works - you can save an entry multiple times even if nothing has changed.

However, we have also made this more hidden when a previous submission has been approved, under the assumption that once approved it's less of a primary action to submit it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants