Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key extensibility support #9

Closed
shizhMSFT opened this issue Feb 22, 2022 · 3 comments
Closed

Key extensibility support #9

shizhMSFT opened this issue Feb 22, 2022 · 3 comments
Assignees
@shizhMSFT
Milestone
v1-alpha.1

Comments

@shizhMSFT
Copy link
Contributor

Currently, the siging key and the verification key must be a golang built-in type (e.g. rsa.PrivateKey).

We need to refactor the go-cose library so that Signer and Verifier are interfaces instead of solid structures. With those interface, other developers can make remote signing keys possible and even support FIPS 140-2 by using OpenSSL via CGO.
@thomas-fossati
Copy link
Contributor

Sounds like a good idea.

@sajayantony sajayantony mentioned this issue Mar 9, 2022
Closed
@SteveLasker
Copy link
Contributor

Agreed to move forward.
Next steps: review a design proposal. @shizhMSFT, do you want to provide that?

@SteveLasker SteveLasker added this to the v1-alpha.1 milestone Mar 12, 2022
@shizhMSFT shizhMSFT mentioned this issue Mar 18, 2022
Merged
@shizhMSFT shizhMSFT mentioned this issue Mar 25, 2022
Merged
@shizhMSFT
Copy link
Contributor Author

Addressed in #17

@shizhMSFT shizhMSFT mentioned this issue Apr 20, 2022
Merged
@SteveLasker SteveLasker mentioned this issue Apr 22, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shizhMSFT shizhMSFT

Labels
None yet
Projects
None yet
Milestone
v1-alpha.1
Development

No branches or pull requests
3 participants
@SteveLasker @thomas-fossati @shizhMSFT