Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claims validation consistently #186

Closed
SteveLasker opened this issue Mar 8, 2024 · 3 comments
Closed

Add claims validation consistently #186

SteveLasker opened this issue Mar 8, 2024 · 3 comments
Labels
help wanted Extra attention is needed ready-for-pr
Milestone

Comments

@SteveLasker
Copy link
Contributor

          It could be argued this is essential to do, before merging this.

Originally posted by @OR13 in #183 (comment)

@OR13
Copy link
Contributor

OR13 commented Mar 8, 2024

If we do validation, we should do it based on risk assessment.

  • content type
  • x5t, x5c

There needs to be an argument for "why" we added extra validation logic.

And we need to be sure that we do not overstep the validation and create interoperability issues

@yogeshbdeshpande
Copy link
Contributor

We should prioritise what validation we need to do.
It is un-realistic to do validation of every element , however certain elements are essential to be validated!

Need to do analysis of which one are a priority and then proceed with a PR!

@SteveLasker SteveLasker added ready-for-pr help wanted Extra attention is needed labels Aug 2, 2024
@OR13
Copy link
Contributor

OR13 commented Aug 16, 2024

Lets leave claims validation to the callers, and reduce the code we must maintain.

@OR13 OR13 closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed ready-for-pr
Projects
None yet
Development

No branches or pull requests

3 participants