Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compressed point support from EC2 keys #185

Closed
OR13 opened this issue Mar 8, 2024 · 1 comment · Fixed by #187
Closed

Remove compressed point support from EC2 keys #185

OR13 opened this issue Mar 8, 2024 · 1 comment · Fixed by #187
Labels
enhancement New feature or request ready-for-pr
Milestone

Comments

@OR13
Copy link
Contributor

OR13 commented Mar 8, 2024

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

Point compression causes warnings.

What solution do you propose?

Doing point compression in this library is unnecessary, we can require keys to be in uncompressed form, and then throw errors when compressed point keys are passed, and instruct the user to do point compression before calling our interfaces.

What alternatives have you considered?

Doing point compression in our library

Any additional context?

related to #178

and #168 (comment)

@OR13 OR13 added the enhancement New feature or request label Mar 8, 2024
@SteveLasker SteveLasker added this to the Future milestone Mar 8, 2024
@OR13
Copy link
Contributor Author

OR13 commented Mar 8, 2024

If a test confirms errors are thrown for compressed points, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-pr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants