From 9e04be286ccd480eef7ff856e937bac60d4a03e2 Mon Sep 17 00:00:00 2001 From: Richard Kellner Date: Thu, 25 May 2017 15:41:07 +0200 Subject: [PATCH 1/3] Added proper exception when cnnection fail In case kraken server return something different that 20x response we shall throw an proper http exception. Otherwise it would try to parse JSON and we got JSONDecodeError exception which is confusing. This way developers could handle better connection problems in their apps in case kraken has problems. --- krakenex/connection.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/krakenex/connection.py b/krakenex/connection.py index 1dc3b6e..8906558 100644 --- a/krakenex/connection.py +++ b/krakenex/connection.py @@ -78,4 +78,7 @@ def _request(self, url, req = {}, headers = {}): self.conn.request('POST', url, data, headers) response = self.conn.getresponse() + if response.status not in (200, 201, 202): + raise http.client.HTTPException + return response.read().decode() From 30f36664e38d986efca0edb6e426962ba9bc7fd1 Mon Sep 17 00:00:00 2001 From: Richard Kellner Date: Thu, 25 May 2017 15:46:53 +0200 Subject: [PATCH 2/3] Improved exception to show also an status code Minor update when raising an exception lets show the status code so developer has more information what is going on. --- krakenex/connection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/krakenex/connection.py b/krakenex/connection.py index 8906558..d792502 100644 --- a/krakenex/connection.py +++ b/krakenex/connection.py @@ -79,6 +79,6 @@ def _request(self, url, req = {}, headers = {}): response = self.conn.getresponse() if response.status not in (200, 201, 202): - raise http.client.HTTPException + raise http.client.HTTPException(response.status) return response.read().decode() From b63d975440a717ce8bc4a701648c9d2991d9d49f Mon Sep 17 00:00:00 2001 From: Richard Kellner Date: Thu, 25 May 2017 15:51:17 +0200 Subject: [PATCH 3/3] Updated changelog with PR #17 --- CHANGELOG.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f1c51fb..2e6a575 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -20,6 +20,14 @@ Changed ^^^^^^^ * Renamed ``NEWS`` to ``CHANGELOG``. +[v0.1.5a] - Unreleased (Anyday) +------------------------------ + +Added +^^^^^ +* Updated kraken connection to raise error in case it doesnt receive 20x status code. + + [v0.1.4] - 2017-03-27 (Monday) ------------------------------