Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lossless param #90

Open
timkelty opened this issue May 4, 2021 · 2 comments · May be fixed by #111
Open

Support lossless param #90

timkelty opened this issue May 4, 2021 · 2 comments · May be fixed by #111
Labels
bug Something isn't working

Comments

@timkelty
Copy link

timkelty commented May 4, 2021

There seems to be some logic for this (https://github.com/venveo/serverless-sharp/blob/master/src/ImageHandler.js#L169-L171) , but passing it as a query param results in a thrown 400/ExpectationType.

Related:

@timkelty
Copy link
Author

timkelty commented May 4, 2021

After further digging, I can get it to accept the param, but it must be a string "true". We should probably coerce to a boolean like Imgix does.

That said, it's hard to tell what or if it is doing anything. I'm not sure what the expected behavior is when lossless is combined with q…

@Mosnar
Copy link
Collaborator

Mosnar commented May 16, 2021

This is fixed in this PR: #94

@Mosnar Mosnar added the bug Something isn't working label May 16, 2021
@Mosnar Mosnar linked a pull request Sep 6, 2022 that will close this issue
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants