Center tokens. #69
Open
Center tokens. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 14, 2015 09:36
…eldAlignmentRight.
…xtAlignment mirrors tokenField alignment.
…eldAlignmentRight.
…ext field location based on text length.
…lignment property.
| @@ -24,15 +24,12 @@ | |||
|
|
|||
| @implementation VENBackspaceTextField | |||
|
|
|||
| - (BOOL)keyboardInputShouldDelete:(UITextField *)textField | |||
| { | |||
| - (void)deleteBackward { | |||
There was a problem hiding this comment.
keyboardInputShouldDelete seemed to prevent textField:shouldChangeCharactersInRange:replacementString from being called on backspaces (and possibly other unknown side effects). deleteBackward doesn't seem to have the same limitation.
|
|
|
Found a solution that works from here but seems risky in terms of getting rejected for private API usage... @ayanonagon ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecated
minInputWidth.When adding logic to center icons, I also modified the logic for positioning the
inputTextField. Now, the text it contains is treated like a token. So, theinputTextFieldgoes wherever the token positioning logic puts this placeholder token (whosetitleTextis the current text in theinputTextField). Because the token locations are now refreshed every time the user inputs a character, thetokenFieldwill now create newlines while the user types as necessary, eliminating the need for aminInputWidth.More frequent updating of the token locations is critical for centering to maintain the "centered" feel as illustrated by the gif below.
Fix #66.