-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samtools dependency #111
Comments
Literally the next line after the one you quoted reads:
But I agree
|
I saw the next line about pysam. That installed fine with pip as suggested. However, I still needed to install samtools after that. |
Aha, ok I get it. That seems wrong, because pysam includes htslib (which is samtools), as far as I understand. Or maybe I'm misunderstanding, and you're saying that samtools can be used e.g. to sort BAM files, and this might be required to run velocyto? That might be a good thing to point out generally, but it's not strictly a requirement for running velocyto. |
Igor is right, samtools is a requirement. Internally velocyto uses Popen to
call samtools sort.
I will change the instructions in the tutorial.
|
Ok, I never noticed probably because I had samtools installed for some other reason. If the code is not too complicated and you want to drop the dependency on samtools instead, you can run any samtools command from pysam:
|
Hi, Thanks for discussing this issue. |
I installed samtools. However it still comes back with same error. Can someone advice, where I should place the samtools directory for it to be read properly by velocyto?
Here is a complete output |
@saeedfc It sounds like you are trying to install it manually ("where I should place the samtools directory"). The solution would be to add it to your PATH, but try installing samtools with conda. If you are using conda for other dependencies, you should use it for all dependencies, including samtools. |
Hi,
|
Solved.
Thanks a lot @igordot and velocyto team |
or rather install samtools using conda solves the problem automatically. |
for linux/ ubuntu, I solved this problem by 'sudo apt-install samtools' |
@gauravsinghrathore that works like a charm! thanks a bunch |
@sky1ove thanks ! 'sudo yum install samtools' solved the problem for me on a centos7 machine |
The tutorial's instructions still haven't been updated. |
It might be worthwhile to add samtools to the installation requirements list. I used the suggested command:
Then I found out about the samtools requirement after trying to run velocyto. Installing samtools separately led to numpy version conflicts. It was fixable, but it's probably best to just add it to the initial install command.
On a related note, pandas is also a requirement, but it is not listed.
The text was updated successfully, but these errors were encountered: