Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joshmh/globalize2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: veger/globalize2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 30, 2009

  1. First attempt to ignore values for the default locale, ie to not stor… 

    …e them in

the translations table
    @veger
    veger committed Dec 30, 2009
    Copy the full SHA
    9d76c9f View commit details

  2. Storing an additional language is not updating the translated fields … 

    …of the

original language anymore (if only translated fields are updated, this even saves
an SQL UPDATE command!)
    @veger
    veger committed Dec 30, 2009
    Copy the full SHA
    e63d2b6 View commit details

  3. Put save_translations! back to after_save (and the default language c… 

    …heck to before_save) to keep orginal functionalities
    @veger
    veger committed Dec 30, 2009
    Copy the full SHA
    a1fc094 View commit details

  4. Fixed update to pass all tests (or updated test for new situation) 

    Removed check_default_language and added test for default_locale when adding values to the record
    @veger
    veger committed Dec 30, 2009
    Copy the full SHA
    2d16af1 View commit details
Loading