Refactor to move ChartState to vegafusion core #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
added a commit
that referenced
this pull request
Oct 17, 2024
This reverts commit d7120b8.
jonmmease
added a commit
that referenced
this pull request
Oct 17, 2024
jonmmease
added a commit
that referenced
this pull request
Oct 17, 2024
jonmmease
added a commit
that referenced
this pull request
Oct 17, 2024
jonmmease
added a commit
that referenced
this pull request
Nov 16, 2024
* Move ChartState to vegafusion-core, add VegaFusionRuntimeTrait * format * fmt * type fixes
jonmmease
added a commit
that referenced
this pull request
Nov 16, 2024
jonmmease
added a commit
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR that moves the ChartState struct up from
vegafusion-runtimetovegafusion-core. The motivation is that in the future we want to use the ChartState construct fromvegafusion-wasm, which does not depend onvegafusion-runtime.To make this work, I added a VegaFusionRuntimeTrait to
vegafusion-core, and write the ChartState implementation based on this. Then the trait is implemented in vegafusion-runtime.