-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use resolve "shared" instead of steps to fix artifacts in grouped density transform #9106
Conversation
@@ -24,7 +24,8 @@ | |||
"extent": [10, 500], | |||
"counts": true, | |||
"steps": 200, | |||
"as": ["value", "density"] | |||
"as": ["value", "density"], | |||
"resolve": "shared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the input Vega-Lite spec has:
{
"density": "value",
"bandwidth": 10,
"groupby": ["Measurement"],
"extent": [10, 500],
"counts": true,
"steps": 200
}
Since groupby
is defined we get "resolve": "shared"
. "steps": 200
is still there because it's explicitly specified in the Vega-Lite transform.
I'm teaching a class starting middle of next week which would benefit from having this included. Is there any chance for a patch release of VL that includes this fix before then? It is not critical as I can work around it by teaching |
Awesome, thank you!! |
…d density transform (vega#9106) * Use resolve shared instead of steps * Update density tests * chore: update examples [CI] --------- Co-authored-by: GitHub Actions Bot <[email protected]>
That's great, thank you so much! |
Is there a build process that takes some time before the URL https://vega.github.io/schema/vega-lite/v5.15.1.json goes live? Or is there a separate manual step for that? |
There is a build process but I got a failure email. @kanitw can you check? |
Reran it and worked now. |
…d density transform (vega#9106) * Use resolve shared instead of steps * Update density tests * chore: update examples [CI] --------- Co-authored-by: GitHub Actions Bot <[email protected]>
Closes #9078