Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should scale nice be true when domain is specified as exact values? #7156

Closed
donghaoren opened this issue Jan 6, 2021 · 2 comments · Fixed by #7157
Closed

Should scale nice be true when domain is specified as exact values? #7156

donghaoren opened this issue Jan 6, 2021 · 2 comments · Fixed by #7157
Assignees
Milestone

Comments

@donghaoren
Copy link
Contributor

Consider the following spec:

{
  "data": {"values": [{"a": "A", "b": 28}]},
  "mark": "bar",
  "encoding": {
    "x": {"field": "b", "type": "quantitative", "scale": {"domain": [0, 150]}}
  }
}

image

I would expect that the domain is exactly [0, 150] as explicitly set.

@jwoLondon
Copy link
Contributor

I agree this would be helpful default behaviour for an explicit domain to override any nice settings.

@domoritz
Copy link
Member

domoritz commented Jan 6, 2021

Good idea. Done in #7157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants