Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid encoding channel should fail more gracefully #3415

Closed
kanitw opened this issue Feb 24, 2018 · 2 comments · Fixed by #3426
Closed

Invalid encoding channel should fail more gracefully #3415

kanitw opened this issue Feb 24, 2018 · 2 comments · Fixed by #3426
Labels
Area - Visual Encoding Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first)
Milestone
x.x Visual Encoding

Comments

@kanitw
Copy link
Member

kanitw commented Feb 24, 2018

For example, if I type _y instead of y, everything crashes.

{
  "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
  "data": {"url": "data/movies.json"},
  "mark": "bar",
  "encoding": {
    "x": {
      "bin": true,
      "field": "IMDB_Rating",
      "type": "quantitative"
    },
    "_y": {
      "aggregate": "count",
      "type": "quantitative"
    }
  }
}

image
@kanitw kanitw added Help wanted Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first) labels Feb 24, 2018
@kanitw kanitw added this to the 2.x Visual Encoding Patches milestone Feb 24, 2018
@kanitw
Copy link
Member Author

kanitw commented Feb 24, 2018

We should just ignore the invalid channel instead.

@invokesus invokesus mentioned this issue Feb 28, 2018
Merged
5 tasks
@kanitw
Copy link
Member Author

kanitw commented Mar 4, 2018

Will be fixed in #3426

@kanitw kanitw closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Visual Encoding Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first)
Projects
None yet
Milestone
x.x Visual Encoding
Development

Successfully merging a pull request may close this issue.

Add Invalid Encoding Channel Warning invokesus/vega-lite
1 participant
@kanitw