Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mark.md to include ranged marks. #2213

Closed
kanitw opened this issue Apr 18, 2017 · 8 comments
Closed

Update mark.md to include ranged marks. #2213

kanitw opened this issue Apr 18, 2017 · 8 comments
Assignees
Milestone

Comments

@kanitw
Copy link
Member

kanitw commented Apr 18, 2017

We haven't shown how to use x2 and y2 at all

@kanitw kanitw added this to the 2.0.0 Docs & Examples milestone Apr 18, 2017
@kanitw kanitw self-assigned this Apr 21, 2017
@kanitw kanitw assigned ayush29feb and unassigned kanitw Jun 13, 2017
@kanitw
Copy link
Member Author

kanitw commented Jun 13, 2017

Step 1. Create examples for different ranged mark types

(You can submit one or more example at a time -- whichever you think makes it easier for us to review.)

Step 2. Add them to different parts of marks.md with description paragraphs

@vega vega deleted a comment from domoritz Jun 13, 2017
@ayush29feb
Copy link

ayush29feb commented Jun 19, 2017

Ran into some issues while recreating the https://vega.github.io/vega/examples/timelines/ example.

Another small thing, the size property isn't documented for rules mark in the docs. Maybe we should include it.

Here is what I got so far.
image

{
  "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
  "data": {
    "name": "people",
    "values": [
      {
        "label": "Washington",
        "born": -7506057600000,
        "died": -5366196000000,
        "enter": -5701424400000,
        "leave": -5453884800000
      }
      ...
    ]
  },
  "layer": [
    {
      "mark": "rule",
      "encoding": {
        "x": {
          "field": "born",
          "type": "temporal",
          "timeUnit": "year",
          "axis": {"title": "Year"}
        },
        "x2": {
          "field": "died",
          "type": "temporal",
          "timeUnit": "year"
        },
        "y": {
          "field": "label",
          "type": "nominal",
          "axis": {"title": "President"}
        },
        "color": {"value": "black"},
        "size": {"value": 2}
      }
    },
    {
      "mark": "rule",
      "encoding": {
        "x": {
          "field": "enter",
          "type": "temporal",
          "timeUnit": "year"
        },
        "x2": {
          "field": "leave",
          "type": "temporal",
          "timeUnit": "year"
        },
        "size": {"value": 4},
        "y": {
          "field": "label",
          "type": "nominal"
        },
        "color": {"value": "red"}
      }
    }
  ]
}

@ayush29feb
Copy link

For the confidence intervals, do we have a aggregate function to calculate the 95% value? I am currently plotting q1 and q3

@ayush29feb
Copy link

ayush29feb commented Jun 19, 2017

For the ranged area chart, is this example not good enough?
http://www.ayush.xyz/vega-editor-demo/?mode=vega-lite&spec=confidence_interval
image

(same issue, do we have a aggregate function to calculate 95%?)

@domoritz
Copy link
Member

vega-lite doesn't allow multiple data sources so I couldn't figure out how to load both presidents and events described in the vega doc

Use layers or lookup

@domoritz
Copy link
Member

Another small thing, the size property isn't documented for rules mark in the docs. Maybe we should include it.

Please send a separate PR!

@kanitw
Copy link
Member Author

kanitw commented Jun 19, 2017

For the confidence intervals, do we have a aggregate function to calculate the 95% value? I am currently plotting q1 and q3

They are called ci0 and ci1 -- I believe. (See Vega docs and if Vega-Lite docs do not have them, please help update accordingly.) :)

@kanitw kanitw modified the milestones: 2.0.0 Docs & Examples, 2.0.0 Critical Feature & Patches Jun 29, 2017
@kanitw kanitw mentioned this issue Aug 24, 2017
8 tasks
@kanitw
Copy link
Member Author

kanitw commented Aug 24, 2017

Consolidated as a part of #2854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants