Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label rotation does not work for row when labelAngle = 0 #1664

Closed
3 tasks done
chuanconggao opened this issue Nov 3, 2016 · 2 comments
Closed
3 tasks done

Label rotation does not work for row when labelAngle = 0 #1664

chuanconggao opened this issue Nov 3, 2016 · 2 comments
Assignees

Comments

@chuanconggao
Copy link

Please:

  • Check for duplicate issues
  • Describe how to reproduce the bug / the goal of the new feature request
    Can be reproduced using the online editor:
{
    "data": {"values": [
      {"a": "A","b": 28, "c": "A"}, 
      {"a": "B","b": 55, "c": "A"}, 
      {"a": "C","b": 43, "c": "A"}
    ]},
    "mark": "bar",
    "encoding": {
        "x": {
            "field": "b", "type": "quantitative", "axis": false
        },
        "y": {
            "field": "a", "type": "nominal", "axis": false
        },
        "row": {
            "field": "c", "type": "nominal",
            "axis": {
                "title": "", "labelAngle": 0
            }
        }
    }
}
  • Provide an example spec and/or screenshots (if applicable)
    When labelAngle is not set, we have:
    vega 1
    However, when labelAngle = 0, there is no difference from default:
    vega 1
    Further, when labelAngle = 360, it works:
    vega 2

It seems labelAngle = 0 is treated the same as default. How can I force it without using 360?

@kanitw
Copy link
Member

kanitw commented Nov 4, 2016

Thanks for reporting. This is definitely a bug.

Since you can get around using 360, I guess we can punt on this and fix it as a part of 2.0 release?
If you have pressing need for a patch release, let us know. I can try to fix and make a 1.x patch release. Thank you.

@kanitw kanitw added this to the 2.0.0-pre Important Feature & Patches milestone Nov 4, 2016
@chuanconggao
Copy link
Author

Using 360 works for me right now. So surely there is no need to rush it. 😄 Really looking forward to 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants