Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ppi argument #1192

Open
joelostblom opened this issue Jul 14, 2023 · 2 comments
Open

Support ppi argument #1192

joelostblom opened this issue Jul 14, 2023 · 2 comments

Comments

@joelostblom
Copy link

Vega-Lite 5.8 added support for a ppi argument to their CLI in vega/vega-lite#8854. Being able to control the ppi of a figure is quite useful since that would give higher resolution without changing the displayed size (as scale/scale_factor does). Would it be possible to add a similar ppi setting to vega-embed?

@domoritz
Copy link
Member

I think it makes sense. We already have scaleFactor and I'm not sure whether we can use ppi in view.toImageURL in

const url = await view.toImageURL(ext, scaleFactor);
. Do you know what we need to change to make ppi work?

@joelostblom
Copy link
Author

Nope, I'm not sure what to update but thought it would make sense to bring parity here with ppi since scaleFactor already exists as you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants