Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Temporal examples in vegafusion #3702

Merged
merged 5 commits into from
Nov 24, 2024
Merged

ci: Temporal examples in vegafusion #3702

merged 5 commits into from
Nov 24, 2024

Conversation

dangotbanned
Copy link
Member

Will close #3701

@dangotbanned dangotbanned changed the title fix: Temporal example in vegafusion fix: Temporal examples in vegafusion Nov 24, 2024
Getting a different error now, but pushing as is
@mattijn
Copy link
Contributor

mattijn commented Nov 24, 2024

How is changing the tests a fix?

@dangotbanned
Copy link
Member Author

dangotbanned commented Nov 24, 2024

How is changing the tests a fix?

Maybe I misunderstood:

But my opinion in (#3701 (comment))

I'm torn on whether to make all date parsing a little less efficient by always checking for this as a special case (with a \d{4} regular expression) in VegaFusion. It's not a hard fix for our tests, and I can mark it prominently as a breaking change with instructions in the VegaFusion and Altair 5 changelogs. Open to suggestions.

@jonmmease IMO I don't think these should be interpreted as dates without a format specifier.

A 4 digit number (string?) is so ambiguous

@mattijn I'm happy to revert the examples, if @jonmmease is fixing on the rust-side

@mattijn
Copy link
Contributor

mattijn commented Nov 24, 2024

Better not change the encoding of these examples. This will change the appearance of the charts. This are real altair examples as are seen in the documentation. Maybe we can skip these examples with the reported issue when doing vegafusion related tests for now.

Somewhat of a drive-by, but I fixed the `ruff` directives so they apply to only the parameterize blocks

All other changes are to resolve rule violations that were hidden

#3701
@dangotbanned
Copy link
Member Author

Better not change the encoding of these examples. This will change the appearance of the charts. This are real altair examples as are seen in the documentation. Maybe we can skip these examples with the reported issue when doing vegafusion related tests for now.

@mattijn I've used an xfail on these instead of a skip

If the issue does get resolved upstream - we can find out by them emitting an xpassed

@dangotbanned
Copy link
Member Author

dangotbanned commented Nov 24, 2024

Not sure what the title should be for this PR

Edit: thanks @mattijn 😃

@dangotbanned dangotbanned marked this pull request as ready for review November 24, 2024 13:24
@mattijn mattijn changed the title fix: Temporal examples in vegafusion ci: Temporal examples in vegafusion Nov 24, 2024
@mattijn mattijn enabled auto-merge (squash) November 24, 2024 13:26
@mattijn mattijn merged commit 922eac3 into main Nov 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite is failing with Vegafusion 2
2 participants