-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Temporal examples in vegafusion
#3702
Conversation
vegafusion
vegafusion
Getting a different error now, but pushing as is
How is changing the tests a fix? |
Maybe I misunderstood:
But my opinion in (#3701 (comment))
@mattijn I'm happy to revert the examples, if @jonmmease is fixing on the |
Better not change the encoding of these examples. This will change the appearance of the charts. This are real altair examples as are seen in the documentation. Maybe we can skip these examples with the reported issue when doing vegafusion related tests for now. |
Somewhat of a drive-by, but I fixed the `ruff` directives so they apply to only the parameterize blocks All other changes are to resolve rule violations that were hidden #3701
@mattijn I've used an xfail on these instead of a skip If the issue does get resolved upstream - we can find out by them emitting an xpassed |
Not sure what the title should be for this PR Edit: thanks @mattijn 😃 |
vegafusion
vegafusion
Will close #3701