Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to intervention/image 3.0 #625

Open
MegaphoneJon opened this issue Dec 8, 2023 · 3 comments
Open

Upgrade to intervention/image 3.0 #625

MegaphoneJon opened this issue Dec 8, 2023 · 3 comments

Comments

@MegaphoneJon
Copy link
Contributor

One of the most popular issues on this repo is support for animated GIFs, which our image manipulation library didn't support.

As of this morning, intervention/image 3.0 has been released, which supports animated GIFs.

We should try updating composer.json to pull in the latest versoin.

@mattwire
Copy link
Collaborator

@MegaphoneJon Happy to update if you can confirm it works?

@MegaphoneJon
Copy link
Contributor Author

After I posted this I did some more research and we definitely will need to make some code changes.

There's also a PHP 8.1 requirement. So short of maintaining a 3.x and 4.x version of this extension, I don't know that there's a good short-term answer.

I no longer have clients interested in this, so I'll leave it to those with more vested interest to work on this.

@MegaphoneJon
Copy link
Contributor Author

Just a thought - we could abstract away the differences between v2 and v3 of intervention/image. Then we could offer an animated GIF version of Mosaico.

Part of me thinks that's too much work and we should just wait for Civi's minimum PHP version to be 8.1, but 7.4 is still the most popular version, and every change in server requirements means losing users. So if someone is invested enough in this feature, that seems like the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants