Improve error handling on image params #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if this regex doesn't get matched https://github.com/veda-consulting-company/uk.co.vedaconsulting.mosaico/blob/2.x/CRM/Mosaico/ImageFilter.php#L37 it would still be used on the final image usage which wouldn't be over AJAX but I think that this is probably sensible none the less, however I would also think that you may want to adjust the other 2 Exceptions in this function as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner handling of method/params parameters for image processing endpoint. If parameters are invalid log an error and return bad request.
Before it was inconsistent and there seems little point throwing an exception or fatal error because the endpoint is generally used over AJAX.
@seamuslee001