Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error message on resizing image and prevent hard fail #433

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

monishdeb
Copy link
Contributor

Mosaico uses the Intervention library to handle image manipulation. we've found a few instances where this throws a fatal error and breaks the application, when we think it should log an error to file, perhaps throw a UI warning -- but not block use of the system. Two cases where it causes hard failure:

  1. Files in the images/uploads folder (i.e. the Mosaico gallery) had improper permissions, and
  2. when there were files there that were not valid image files.

BEFORE

Hard failure breaks the design screen

AFTER

Capture the error messages and notify the user on compose screen.

@lcdservices
Copy link

This works as expected. The UI can still be used.

@eileenmcnaughton
Copy link
Collaborator

Seems OK to me - @mattwire ?

@mattwire
Copy link
Collaborator

This seems sensible and has been tested by @lcdservices

@mattwire mattwire merged commit 5a729ca into veda-consulting-company:2.x Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants