From 49c519ed21e5fbc23cd562c937084fd40804c7ac Mon Sep 17 00:00:00 2001 From: Scott Opell Date: Tue, 10 Dec 2024 12:15:14 +0100 Subject: [PATCH 1/3] Updates smp-cli to use latest version --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index 91c11ac73f7c8..a3a9f43eb0646 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -105,7 +105,7 @@ jobs: - name: Set SMP version id: experimental-meta run: | - export SMP_CRATE_VERSION="0.16.1" + export SMP_CRATE_VERSION="0.19.3" echo "smp crate version: ${SMP_CRATE_VERSION}" echo "SMP_CRATE_VERSION=${SMP_CRATE_VERSION}" >> $GITHUB_OUTPUT From 13cb23b8fdff983bd12d1b5c15b905cfc97cd13a Mon Sep 17 00:00:00 2001 From: Scott Opell Date: Tue, 10 Dec 2024 13:40:13 +0100 Subject: [PATCH 2/3] Fixes incorrect env var substitution in regression workflow --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index a3a9f43eb0646..32a2327c5e0ac 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -407,7 +407,7 @@ jobs: --target-config-dir ${{ github.workspace }}/regression/ \ --warmup-seconds ${{ env.SMP_WARMUP_SECONDS }} \ --submission-metadata ${{ runner.temp }}/submission-metadata \ - --replicas {{ env.SMP_REPLICAS }} + --replicas ${{ env.SMP_REPLICAS }} - uses: actions/upload-artifact@v4 with: From 70c268e15a6d3acc609ae00fd4bc96c68c5bf723 Mon Sep 17 00:00:00 2001 From: Scott Opell Date: Tue, 10 Dec 2024 18:53:56 +0100 Subject: [PATCH 3/3] Increases timeout --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index 32a2327c5e0ac..cddbf1929f4bc 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -367,7 +367,7 @@ jobs: submit-job: name: Submit regression job runs-on: ubuntu-22.04 - timeout-minutes: 70 + timeout-minutes: 120 needs: - should-run-gate - resolve-inputs