Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer Improvements: refactor buffer configuration code to handle existing and chained styles #9918

Closed
Tracked by #9476
tobz opened this issue Nov 4, 2021 · 0 comments · Fixed by #9959
Closed
Tracked by #9476
Assignees
Labels
domain: buffers Anything related to Vector's memory/disk buffers type: task Generic non-code related tasks

Comments

@tobz
Copy link
Contributor

tobz commented Nov 4, 2021

Part of the Buffer Improvements RFC (RFC, #9476)

We need to refactor the existing buffer configuration code so that it can suitably represent both the existing configuration style and the new chained style.

In practice, what this will likely end up being is a custom serializer implementation that can parse the current style, but when toggled to a specific mode ("overflow" being the obvious candidate here), it would parse additional fields related to the chained buffers.

One part we'll need to flesh out here is how much we can reasonably stray from the existing style. There's likely some cookie-cutter buffer topologies we could construct based purely on the existing configuration fields, but if a user opts into the advanced configuration "mode"... do we:

  • make the other fields invalid and everything has to be done in the advanced mode?
  • do we use the existing fields to define the first buffer, and advanced mode defines any subsequent buffers? etc

This will likely require some noodling with what is reasonable possible in a custom serializer implementation, and what ends up looking reasonable when written in a configuration file.

@tobz tobz added the type: task Generic non-code related tasks label Nov 4, 2021
@tobz tobz mentioned this issue Nov 4, 2021
18 tasks
@tobz tobz added the domain: buffers Anything related to Vector's memory/disk buffers label Nov 4, 2021
@tobz tobz closed this as completed in #9959 Nov 9, 2021
@tobz tobz self-assigned this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: buffers Anything related to Vector's memory/disk buffers type: task Generic non-code related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant