Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventsSent support to common new-sink Driver code #9705

Closed
Tracked by #9325
bruceg opened this issue Oct 19, 2021 · 0 comments · Fixed by #9801
Closed
Tracked by #9325

Add EventsSent support to common new-sink Driver code #9705

bruceg opened this issue Oct 19, 2021 · 0 comments · Fixed by #9801
Assignees
@fuchsnj

Comments

@bruceg
Copy link
Member

bruceg commented Oct 19, 2021

@bruceg We could likely move it to Driver instead, since "after we store the service future but before we poll it it" is the perfect spot to emit EventsSent

Originally posted by @tobz in #9614 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuchsnj fuchsnj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement(sinks): enforce EventsSent instrumentation for new-style sinks vectordotdev/vector
2 participants
@bruceg @fuchsnj