Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect process metrics #9626

Closed
jszwedko opened this issue Oct 14, 2021 · 12 comments
Closed

Collect process metrics #9626

jszwedko opened this issue Oct 14, 2021 · 12 comments
Labels
domain: sources Anything related to the Vector's sources type: feature A value-adding code addition that introduce new functionality.

Comments

@jszwedko
Copy link
Member

A user requested the ability to record metrics by process (like CPU, memory, etc.).

I think this could be a separate source or incorporated into the host_metrics source.

@jszwedko jszwedko added domain: sources Anything related to the Vector's sources type: feature A value-adding code addition that introduce new functionality. labels Oct 14, 2021
@LeeTeng2001
Copy link
Contributor

I would love to see this

@LeeTeng2001
Copy link
Contributor

Currently I rely on vector host metrics to scrape details about host machine, it's awesome as I don't need another agent like node scrapper to provide this information

@LeeTeng2001
Copy link
Contributor

can i get my hands on this?

@jszwedko
Copy link
Member Author

can i get my hands on this?

Sure!

@LeeTeng2001
Copy link
Contributor

Hi, since heim wouldn't be replaced in a short while, I cannot implement process metrics using heim crates. can we use both dependencies and only sysinfo for process metrics?

@LeeTeng2001
Copy link
Contributor

In other word, should I make a PR that only uses sysinfo for process metrics or a PR with heim completely replaced?

@LeeTeng2001
Copy link
Contributor

I already got a working sample, thanks for the kind & quick response! Vector is a great software, would love to contribute

@pront
Copy link
Member

pront commented Nov 5, 2024

Hi @LeeTeng2001, first of all, thank you for your interest in contributing!

Hi, since heim wouldn't be replaced in a short while, I cannot implement process metrics using heim crates. can we use both dependencies and only sysinfo for process metrics?

I think it is fine using sysinfo to implement things that heim doesn't support.

Regarding the heim vs sysinfo debate, the only concern IMO if sysinfo can satisfy all metrics produced by the host_metrics source.

It is obvious that sysinfo is significantly more popular now and generally I would be in favor of using it going forward. But that will require some extra work and validation.

And yes, ideally we should only use one dependency.

@LeeTeng2001
Copy link
Contributor

I would like to remove heim but I fell like it would be too much of a PR & out of this issue scope, I'd like to keep the PR small and only implement process metrics for now.

@LeeTeng2001
Copy link
Contributor

This issue is closed, may I asked when will the next release be? I would love to use this feature

@pront
Copy link
Member

pront commented Nov 21, 2024

The next release is 0.43. Expected to happen on Dec 2nd. You can see this via the milestone. Also, you can see our public calendar.vector.dev

@pront
Copy link
Member

pront commented Nov 21, 2024

#21861

@pront pront closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants