Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vector acknowledgements support to splunk_hec sink #7666

Closed
bruceg opened this issue May 28, 2021 · 4 comments
Closed

Add Vector acknowledgements support to splunk_hec sink #7666

bruceg opened this issue May 28, 2021 · 4 comments
Labels
sink: humio_logs Anything `humio_logs` sink related sink: splunk_hec Anything `splunk_hec` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@bruceg
Copy link
Member

bruceg commented May 28, 2021

Ref #7337
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. sink: humio_logs Anything `humio_logs` sink related labels May 28, 2021
@bruceg bruceg changed the title Add acknowledgements support to humio_logs Add acknowledgements support to splunk_hec May 29, 2021
@bruceg bruceg added the sink: splunk_hec Anything `splunk_hec` sink related label May 29, 2021
@bruceg bruceg changed the title Add acknowledgements support to splunk_hec Add acknowledgements support to splunk_hec sink May 29, 2021
@bruceg
Copy link
Member Author

bruceg commented May 29, 2021

Noting that the humio_logs shares the splunk_hec infrastructure, so resolving this may complete support for both.

@binarylogic binarylogic changed the title Add acknowledgements support to splunk_hec sink Add Vector acknowledgements support to splunk_hec sink Oct 5, 2021
@binarylogic
Copy link
Contributor

Also noting that this differs from the Splunk specific acknowledgements mentioned in #2374

@jszwedko
Copy link
Member

jszwedko commented Oct 5, 2021

I think this and #2374 are very related though. If we add support for e2e's acks to the splunk_hec sink, I think it should be wired up using Splunk's idea of acknowledgements.

@jszwedko
Copy link
Member

This was wired up in #10135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: humio_logs Anything `humio_logs` sink related sink: splunk_hec Anything `splunk_hec` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jszwedko @bruceg @binarylogic