Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic *_keys and *_values Remap functions #5785

Closed
1 task
binarylogic opened this issue Jan 1, 2021 · 2 comments
Closed
1 task

Magic *_keys and *_values Remap functions #5785

binarylogic opened this issue Jan 1, 2021 · 2 comments
Labels
domain: vrl Anything related to the Vector Remap Language needs: approval Needs review & approval before work can begin. type: feature A value-adding code addition that introduce new functionality.

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Jan 1, 2021

Yes, I said "magic" 🐰 . #5377, #5784, and #5783 introduce functions that walk and mutate the entire event. They are simple solutions that avoid hard-to-follow traversal/walk constructs in Remap, like the ones being discussed in #4518. These functions are much easier to implement, read, and understand. To avoid the repetitive nature of defining functions that end with _keys and _values it would be nice to get these functions automatically. I'm on the fence with this but wanted to record an explicit decision here before we move forward with the blocked issues.

Requirements

  • Automatically define *_keys and *_values for functions that operate on single values (accept a single value as their first parameter).
@binarylogic binarylogic added type: feature A value-adding code addition that introduce new functionality. domain: vrl Anything related to the Vector Remap Language labels Jan 1, 2021
@binarylogic binarylogic added this to the 2020-12-21 Kryptek Yeti milestone Jan 1, 2021
@binarylogic binarylogic changed the title Magic *_keys and *_values Remap facilities Magic *_keys and *_values Remap functions Jan 1, 2021
@binarylogic binarylogic added the needs: approval Needs review & approval before work can begin. label Jan 1, 2021
@binarylogic
Copy link
Contributor Author

binarylogic commented Jan 1, 2021

@JeanMertz I'd like to get your approval/opinion on this before starting on #5377, #5784, and #5783. I'm not opposed to not doing this and just creating the referenced functions like any other function.

@JeanMertz
Copy link
Contributor

Closing this as we are going to work on iteration this quarter, which should solve this need as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vrl Anything related to the Vector Remap Language needs: approval Needs review & approval before work can begin. type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants