Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encoding.codec non-optional or default to json/ndjson #5196

Closed
binarylogic opened this issue Nov 23, 2020 · 0 comments · Fixed by #5281
Closed

Make encoding.codec non-optional or default to json/ndjson #5196

binarylogic opened this issue Nov 23, 2020 · 0 comments · Fixed by #5281
Assignees
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Nov 23, 2020

#1915 accidentally made encoding.codec non-optional in sinks and defaulting to "text. If we are going to default, the value should be "json" (or "ndjson"), otherwise, the user should be required to provide the option and choose. We made the option explicit so that the user is not surprised with the format, although, I think JSON is what most users would expect if it's supported.

My vote is to default to json/nsjdon when possible, otherwise, require the option.

@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. domain: codecs Anything related to Vector's codecs (encoding/decoding) labels Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants