Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define events for the aws_cloudwatch_logs sink #4960

Closed
10 tasks
jamtur01 opened this issue Nov 11, 2020 · 1 comment
Closed
10 tasks

Define events for the aws_cloudwatch_logs sink #4960

jamtur01 opened this issue Nov 11, 2020 · 1 comment
Labels
domain: observability Anything related to monitoring/observing Vector sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@jamtur01
Copy link
Contributor

As part of finishing https://github.com/timberio/vector-product/issues/14, we need to define internal events for the aws_cloudwatch_logs sink.

Defining events

Requirements

  • Add a InsertSinkNameHereEventProcessed event.
    • Derive an events_processed metric via the emit_metrics method. (example)
  • Add a InsertSinkNameHereEventDiscarded event. This event only occurs if the event does not match the filter.
    • Derive an events_discarded metric via the emit_metrics method. (example)
  • Audit and add events for all possible errors. (example)
    • Derive a processing_errors metrics via the emit_metrics method. (example)
    • Emit a log message that ends with ; discarding event only if the error results in dropping the event. (example.
  • Audit and add events for all component-specific behavior. (example)
  • Ensure that logs in the hot path are rate limited via the rate_limit_secs parameter. (example).
  • Ensure that all log messages start with a capital letter and end with a .. (example)
@jamtur01 jamtur01 added sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: enhancement A value-adding code change that enhances its existing functionality. labels Nov 11, 2020
@binarylogic binarylogic added the domain: observability Anything related to monitoring/observing Vector label Dec 9, 2020
@jamtur01 jamtur01 added this to the 2021-01-04 Xenomass Well milestone Dec 31, 2020
@binarylogic binarylogic removed this from the 2021-02-01 D-Fuel milestone Feb 24, 2021
@bruceg
Copy link
Member

bruceg commented Sep 23, 2021

Replaced by #9325

@bruceg bruceg closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants