Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flaky sources::file::tests::remove_file test #3780

Closed
JeanMertz opened this issue Sep 9, 2020 · 3 comments · Fixed by #5608
Closed

Replace flaky sources::file::tests::remove_file test #3780

JeanMertz opened this issue Sep 9, 2020 · 3 comments · Fixed by #5608
Assignees
Labels
domain: tests Anything related to Vector's internal tests type: bug A code related bug.

Comments

@JeanMertz
Copy link
Contributor

see: https://github.com/timberio/vector/pull/3341/checks?check_run_id=1091003216

Sep 09 12:41:29.227 DEBUG file_server: vector::internal_events::file: files checkpointed. count=1
Sep 09 12:41:29.228 ERROR file_server: vector::internal_events::file: failed reading file for fingerprinting. path="/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.tmpdz8lfL/checkpoints" error=Os { code: 21, kind: Other, message: "Is a directory" }
thread 'main' panicked at 'File wasn't removed', src/sources/file.rs:1456:22
stack backtrace:
   0:        0x1138ad48f - backtrace::backtrace::libunwind::trace::h56b31d02b9b762c6
                               at /Users/runner/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1:        0x1138ad48f - backtrace::backtrace::trace_unsynchronized::h6625ae095e7d53cf
                               at /Users/runner/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2:        0x1138ad48f - std::sys_common::backtrace::_print_fmt::hce8652c3ed9d2e92
                               at src/libstd/sys_common/backtrace.rs:78
   3:        0x1138ad48f - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h83d53b696ac99295
                               at src/libstd/sys_common/backtrace.rs:59
   4:        0x1138d99fe - core::fmt::write::hf81c429634e1f3ed
                               at src/libcore/fmt/mod.rs:1069
   5:        0x1138a3d57 - std::io::Write::write_fmt::had2a3b01a2c037b5
                               at src/libstd/io/mod.rs:1504
   6:        0x1138af8fa - std::sys_common::backtrace::_print::h3e8409ed4be04623
                               at src/libstd/sys_common/backtrace.rs:62
   7:        0x1138af8fa - std::sys_common::backtrace::print::h4fcdfee7c48ce7b5
                               at src/libstd/sys_common/backtrace.rs:49
   8:        0x1138af8fa - std::panicking::default_hook::{{closure}}::ha991e4eca34b4afa
                               at src/libstd/panicking.rs:198
   9:        0x1138af63c - std::panicking::default_hook::h722aa3f5c1c31788
                               at src/libstd/panicking.rs:218
  10:        0x1138afec8 - std::panicking::rust_panic_with_hook::h2cd47f71d6d55501
                               at src/libstd/panicking.rs:511
  11:        0x11390cb80 - std::panicking::begin_panic::had6bdb53dabc7679
  12:        0x11275ca68 - vector::sources::file::tests::remove_file::{{closure}}::h33178d6087336b16
                               at src/sources/file.rs:1456
@JeanMertz
Copy link
Contributor Author

ref #2978

@jamtur01 jamtur01 added type: bug A code related bug. and removed type: bug A code related bug. labels Sep 10, 2020
@jamtur01 jamtur01 self-assigned this Sep 11, 2020
@jamtur01 jamtur01 added this to the 2020-09-14 - The Grid milestone Sep 11, 2020
@jamtur01 jamtur01 removed their assignment Sep 18, 2020
@jamtur01 jamtur01 removed this from the 2020-09-14 - The Grid milestone Sep 18, 2020
@jamtur01
Copy link
Contributor

Removed in #4012.

@jamtur01 jamtur01 changed the title Flaky sources::file::tests::remove_file test Replace flaky sources::file::tests::remove_file test Sep 18, 2020
@jamtur01 jamtur01 added the domain: tests Anything related to Vector's internal tests label Sep 25, 2020
@ktff ktff added this to the 2020-09-28 - Derezzed milestone Sep 27, 2020
@ktff
Copy link
Contributor

ktff commented Oct 18, 2020

Once #4196 is resolved the test can be enabled for mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: tests Anything related to Vector's internal tests type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants