Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At-least-once, or improved delivery / checkpointing for docker_logs source #20121

Closed
jonaslb opened this issue Mar 18, 2024 · 1 comment
Closed
Labels
type: feature A value-adding code addition that introduce new functionality.

Comments

@jonaslb
Copy link

jonaslb commented Mar 18, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

If structured logs are used downstream (for statistics or investigating which events took place), it would be nice to be able to rely a bit more on the correct delivery of those logs. Currently, vector only has "best effort" for docker_logs, and if I read the docs/source correctly, it always reads the logs from the "now" (at the start) timestamp, and not from the start of the container or indeed from any kind of checkpoint. That means the "best effort" is a quite poor effort, where logs will be lost if vector is restarted. This has kept me from using Vector (other tools like promtail or filebeat do checkpointing - don't know if they integrate that with acknowledgements though).

Attempted Solutions

No response

Proposal

  • Introduce checkpointing to the docker_logs source, similar to the file source.
  • Optionally integrate checkpointing with acknowledgements

I see that checkpointing hasn't been enough to upgrade the file source from best-effort to at-least-once delivery, which I assume is due to lack of acknowledgement integration. However, checkpoints is still a big upgrade to the reliability of the source, even without acknowledgement integration. But I do think both together would be enough to "upgrade" the classification.

References

No response

Version

0.36.1 (docker)

@jonaslb jonaslb added the type: feature A value-adding code addition that introduce new functionality. label Mar 18, 2024
@jszwedko
Copy link
Member

Hi @jonaslb ! Thanks for filing this. I think it is a duplicate of #7358 so I'll close this one, but let me know if you disagree!

@jszwedko jszwedko closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants