Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_id and upstream_id metadata fields are lost when event goes through disk buffers. #18572

Closed
StephenWakely opened this issue Sep 15, 2023 · 0 comments · Fixed by #18816
Closed

source_id and upstream_id metadata fields are lost when event goes through disk buffers. #18572

StephenWakely opened this issue Sep 15, 2023 · 0 comments · Fixed by #18816
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: schemas Anything related to internal Vector event schemas

Comments

@StephenWakely
Copy link
Contributor

These fields are not being persisted in the event proto files, so when the event goes through the disk buffers the values are lost. These values need to be added to the proto files.

Needs to be done after #18405 has merged.
@StephenWakely StephenWakely self-assigned this Sep 15, 2023
@jszwedko jszwedko added domain: buffers Anything related to Vector's memory/disk buffers domain: schemas Anything related to internal Vector event schemas labels Sep 15, 2023
@tobz tobz mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: schemas Anything related to internal Vector event schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): add more event metadata to proto vectordotdev/vector
2 participants
@StephenWakely @jszwedko