Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentTrigger CI workflow only works on PRs based from the main repo (not forks) #18437

Open
neuronull opened this issue Aug 30, 2023 · 2 comments
Labels
domain: ci Anything related to Vector's CI environment type: bug A code related bug.

Comments

@neuronull
Copy link
Contributor

Noticed in #18337 (comment) , the GHA we use to checkout the branch for the PR when doing a comment trigger, is not handling the case where the PR is coming from a fork off of the main repo.

This appears to be a limitation of https://github.com/xt0rted/pull-request-comment-branch

It would seem that until this is fixed, the comment trigger workflow won't be able to operate on external contributor PRs that are opened from forks of the main repo.

@neuronull neuronull added domain: ci Anything related to Vector's CI environment type: bug A code related bug. labels Aug 30, 2023
@jszwedko
Copy link
Member

@neuronull did you mean to link to an issue on https://github.com/xt0rted/pull-request-comment-branch? If one doesn't exist, could we open one?

@neuronull
Copy link
Contributor Author

Opened xt0rted/pull-request-comment-branch#385 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

2 participants