Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal_metric gauge whether last config has been loaded successfully or not #18194

Open
nmiculinic opened this issue Aug 9, 2023 · 0 comments
Labels
domain: observability Anything related to monitoring/observing Vector domain: reload Anything related to reloading Vector (updating configuration) type: feature A value-adding code addition that introduce new functionality.

Comments

@nmiculinic
Copy link

A note for the community

For proper vector observability I need to know has the last config been successfully applied or not. Current exposed metrics are insufficient and make it difficult to asses whether vector is running on latest config, or has there been a failure.

Use Cases

No response

Attempted Solutions

Prometheus rule:

vector_reload_errors_total - (vector_reloaded_total or (0 * vector_reload_errors_total)) > 0

is kinda a hack, to get this information. But this fails in case vector was reloaded multiple times successfully in the past. I'm not sure how to get this information properly for alerting purposes

Proposal

Add gauge metric:

vector_valid_config

which will be 1 if the config has been (re)loaded successfully, and 0 if the config cannot be (re)loaded, thus giving something I can alert on in the monitoring system

References

No response

Version

No response

@nmiculinic nmiculinic added the type: feature A value-adding code addition that introduce new functionality. label Aug 9, 2023
@jszwedko jszwedko added domain: observability Anything related to monitoring/observing Vector domain: reload Anything related to reloading Vector (updating configuration) labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: reload Anything related to reloading Vector (updating configuration) type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants