Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the stable rust compiler on windows #1480

Closed
LucioFranco opened this issue Jan 3, 2020 · 2 comments · Fixed by #1560
Closed

Use the stable rust compiler on windows #1480

LucioFranco opened this issue Jan 3, 2020 · 2 comments · Fixed by #1560
Labels
platform: windows Anything `windows` platform related type: tech debt A code change that does not add user value.

Comments

@LucioFranco
Copy link
Contributor

Problem

Currently, we require the nightly rust compiler to compile vector on windows due to the need of the windows_by_handle feature rust-lang/rust#63010. This is our only blocker for using the stable compiler on window.

Proposal

The windows_by_handle feature is only a couple of lines implemented in libstd and its is only a nightly feature to ensure the code can be stabilized into libstd. Because we don't have the same requirements we should vendor this code into vector in its own crate in the lib directory. Doing this will allow us to use the stable compiler.

cc @a-rodin

@LucioFranco LucioFranco added domain: operations type: tech debt A code change that does not add user value. platform: windows Anything `windows` platform related labels Jan 3, 2020
@Hoverbear
Copy link
Contributor

Looks like the only use in Vector is: https://github.com/timberio/vector/blob/b290ceb2aee4242834d434a4bd092fe2a0cece3b/lib/file-source/src/metadata_ext.rs#L23-L30.

Is it better expand this module's code, or create a new module which file-source should depend on?

@LucioFranco
Copy link
Contributor Author

@Hoverbear what ever you think is easiest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: windows Anything `windows` platform related type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants