Make Dockerfile work for develop and other branches #9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we run into problems where Docker Hub's limited machines timeout trying to download our dependencies
turt2live
force-pushed
the
travis/docker-test
branch
from
0abff6d to
3123b42
Compare
jryans
approved these changes
May 16, 2019
|
I'm desperately trying to avoid having secrets anywhere in this whole build, so building from source is ideal. Getting artifacts from buildkite is near impossible and a nightmare (comically, Jenkins makes it as easy as a single curl) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9701 (by not timing out, allowing us to use Docker Hub again)
Fixes #9606 (the rules are already set up, we just need to have something to build 😄)
We force yarn to use a longer network timeout because Docker Hub's limited machines are not capable of downloading the resources fast enough. The tests I've performed on this branch have not failed due to network timeouts, so the value is presumed high enough.
Note: Docker Hub is slow, our builds easily take 20-40 minutes to complete.