Make dropdowns with long options degrade more gracefully #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not enough space was dedicated to a dropdown, it would previously make option text overlap. With this patch, each option can potentially span multiple lines. This is weird, but it's a better degradation than making option text overlap. Signed-off-by: Slavi Pantaleev <[email protected]>
|
woo, thanks! fixes #4815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not enough space was dedicated to a dropdown,
it would previously make option text overlap.
With this patch, each option can potentially span
multiple lines. This is weird, but it's a better
degradation than making option text overlap.
Of course, a proper fix is to dedicate proper attention to each "not enough space dropdown" and allow for enough space to avoid this. But until that's done, it's better to degrade in a nicer way.
Before
After
Signed-off-by: Slavi Pantaleev [email protected]